linux-kernel - Re: [PATCH V9 2/2] firmware: qcom: scm: Add wait-queue handling logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 Jan 2023 20:49:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sibi Sankar <quic_sibis@...cinc.com>, andersson@...nel.org,
        srinivas.kandagatla@...aro.org
Cc:     oe-kbuild-all@...ts.linux.dev, agross@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
        robh+dt@...nel.org, konrad.dybcio@...ainline.org,
        robimarko@...il.com, quic_gurus@...cinc.com,
        Sibi Sankar <quic_sibis@...cinc.com>
Subject: Re: [PATCH V9 2/2] firmware: qcom: scm: Add wait-queue handling logic

Hi Sibi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20230113]
[also build test WARNING on v6.2-rc3]
[cannot apply to robh/for-next linus/master v6.2-rc3 v6.2-rc2 v6.2-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sibi-Sankar/dt-bindings-firmware-qcom-scm-Add-optional-interrupt/20230113-151459
patch link:    https://lore.kernel.org/r/20230113065303.17727-3-quic_sibis%40quicinc.com
patch subject: [PATCH V9 2/2] firmware: qcom: scm: Add wait-queue handling logic
config: m68k-allyesconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b9bb238a0fe7d33d99954dbb0f6d8d9f327e182e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sibi-Sankar/dt-bindings-firmware-qcom-scm-Add-optional-interrupt/20230113-151459
        git checkout b9bb238a0fe7d33d99954dbb0f6d8d9f327e182e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/firmware/qcom_scm-smc.c: In function '__scm_smc_do_quirk_handle_waitq':
>> drivers/firmware/qcom_scm-smc.c:96:35: warning: variable 'flags' set but not used [-Wunused-but-set-variable]
      96 |         u32 wq_ctx, smc_call_ctx, flags;
         |                                   ^~~~~


vim +/flags +96 drivers/firmware/qcom_scm-smc.c

    90	
    91	static int __scm_smc_do_quirk_handle_waitq(struct device *dev, struct arm_smccc_args *waitq,
    92						   struct arm_smccc_res *res)
    93	{
    94		int ret;
    95		struct arm_smccc_args resume;
  > 96		u32 wq_ctx, smc_call_ctx, flags;
    97		struct arm_smccc_args *smc = waitq;
    98	
    99		do {
   100			__scm_smc_do_quirk(smc, res);
   101	
   102			if (res->a0 == QCOM_SCM_WAITQ_SLEEP) {
   103				wq_ctx = res->a1;
   104				smc_call_ctx = res->a2;
   105				flags = res->a3;
   106	
   107				ret = qcom_scm_wait_for_wq_completion(wq_ctx);
   108				if (ret)
   109					return ret;
   110	
   111				fill_wq_resume_args(&resume, smc_call_ctx);
   112				smc = &resume;
   113			}
   114		} while (res->a0 == QCOM_SCM_WAITQ_SLEEP);
   115	
   116		return 0;
   117	}
   118	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (284480 bytes)