linux-kernel - Re: [PATCH v4] sh: avoid using IRQ0 on SH3/4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdW8=JF4CVSJZqQ=FZKRfWALGRVmg+sC+pOw+0TxF680Pg@mail.gmail.com>
Date:   Sat, 14 Jan 2023 13:06:48 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Cc:     Sergey Shtylyov <s.shtylyov@....ru>, Rich Felker <dalias@...c.org>,
        linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v4] sh: avoid using IRQ0 on SH3/4

Hi Adrian,

On Fri, Jan 13, 2023 at 7:49 PM John Paul Adrian Glaubitz
<glaubitz@...sik.fu-berlin.de> wrote:
> > On Jan 13, 2023, at 7:27 PM, Sergey Shtylyov <s.shtylyov@....ru> wrote:
> >> On 5/3/22 11:42 PM, Sergey Shtylyov wrote:
> >> Using IRQ0 by the platform devices is going to be disallowed soon (see [1])
> >> and even now, when IRQ0 is about to be returned by platfrom_get_irq(), you
> >> see a big warning.  The code supporting SH3/4 SoCs maps the IRQ #s starting
> >> at 0 -- modify that code to start the IRQ #s from 16 instead.
> >>
> >> The patch should mostly affect the AP-SH4A-3A/AP-SH4AD-0A boards as they
> >> indeed use IRQ0 for the SMSC911x compatible Ethernet chip...
> >>
> >> [1] https://lore.kernel.org/all/025679e1-1f0a-ae4b-4369-01164f691511@omp.ru/
> >>
> >> Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid")
> >> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> >> Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>
> >> Tested-by: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
> >>
> >> ---
> >> The patch is against Linus Torvalds' 'linux.git' repo.
> >
> >   So, this patch hasn't been merged... may I ask why? :-(
>
> The SH maintainers have been MIA which is why the other maintainers want to kill the architecture again.
>
> I’m seriously considering adopting the architecture.
>
> Not sure whether Linus would grant that though.

Why not?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds