linux-kernel - Re: [PATCH] ASoC: codec: rt5640: Resolve failure to set DMIC clock after playback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8LlnIbvnLGERCNo@sirena.org.uk>
Date:   Sat, 14 Jan 2023 17:25:48 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Jarrah Gosbell <kernel@...ef.tools>
Cc:     Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org,
        Ondrej Jirman <megi@....cz>
Subject: Re: [PATCH] ASoC: codec: rt5640: Resolve failure to set DMIC clock
 after playback

On Sat, Jan 14, 2023 at 12:30:54AM +0000, Jarrah Gosbell wrote:

> rt5640_set_dai_sysclk is called with freq == 0 when playback stops. This
> causes DMIC setup code to fail. I2S interface doesn't need to be active
> for codec to work, so don't clear rt5640->sysclk after
> rt5640_set_dai_sysclk is called with freq == 0.

The goal with set_sysclk() is to record the current clock
frequency, if the clock is stopped it should be set to zero.  If
a machine driver is setting the input clock to zero when it's
still being provided then it should be fixed.  If the device
doesn't need a clock for DMIC (which seems dubious) then whatever
is checking for a clock should be fixed.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)