[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230114205351.czy2fkfrulrl4w6k@skbuf>
Date: Sat, 14 Jan 2023 22:53:51 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Jerry Ray <jerry.ray@...rochip.com>
Cc: Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Russell King <linux@...linux.org.uk>, jbe@...gutronix.de,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6 5/6] dsa: lan9303: Port 0 is xMII port
On Mon, Jan 09, 2023 at 03:18:48PM -0600, Jerry Ray wrote:
> In preparing to move the adjust_link logic into the phylink_mac_link_up
> api, change the macro used to check for the cpu port. In
> phylink_mac_link_up, the phydev pointer passed in for the CPU port is
> NULL, so we can't keep using phy_is_pseudo_fixed_link(phydev).
>
> Signed-off-by: Jerry Ray <jerry.ray@...rochip.com>
> ---
> v5->v6:
> Using port 0 to identify the xMII port on the LAN9303.
> ---
> drivers/net/dsa/lan9303-core.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
> index 792ce6a26a6a..7be4c491e5d9 100644
> --- a/drivers/net/dsa/lan9303-core.c
> +++ b/drivers/net/dsa/lan9303-core.c
> @@ -1063,7 +1063,11 @@ static void lan9303_adjust_link(struct dsa_switch *ds, int port,
> {
> int ctl;
>
> - if (!phy_is_pseudo_fixed_link(phydev))
> + /* On this device, we are only interested in doing something here if
> + * this is an xMII port. All other ports are 10/100 phys using MDIO
> + * to control there link settings.
> + */
> + if (port != 0)
Maybe a macro LAN9303_XMII_PORT would be good, if it was also
consistently used in lan9303_setup()?
> return;
>
> ctl = lan9303_phy_read(ds, port, MII_BMCR);
> --
> 2.17.1
>
Powered by blists - more mailing lists