lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <323b9519-38e4-a7ca-f45d-96cef06fd9bf@linaro.org>
Date:   Sat, 14 Jan 2023 22:26:01 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        linux-arm-msm@...r.kernel.org
Cc:     agross@...nel.org, andersson@...nel.org,
        linux-kernel@...r.kernel.org, bhupesh.linux@...il.com,
        robh+dt@...nel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm6115: Add debug related nodes



On 14.01.2023 22:07, Bhupesh Sharma wrote:
> Add dtsi nodes related to coresight debug units such
> as cti, etm, etr, funnel(s), replicator(s), etc. for
> Qualcomm sm6115 SoC.
> 
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm6115.dtsi | 612 +++++++++++++++++++++++++++
>  1 file changed, 612 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index 478c5d009272..5067910b18ab 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -1237,6 +1237,618 @@ dispcc: clock-controller@...0000 {
>  			#power-domain-cells = <1>;
>  		};
>  
> +		cti0: cti@...0000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x08010000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti1: cti@...1000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x08011000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti2: cti@...2000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x08012000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti3: cti@...3000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x08013000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti4: cti@...4000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x08014000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti5: cti@...5000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x08015000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti6: cti@...6000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x08016000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti7: cti@...7000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x08017000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti8: cti@...8000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x08018000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti9: cti@...9000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x08019000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti10: cti@...a000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x0801a000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti11: cti@...b000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x0801b000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti12: cti@...c000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x0801c000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti13: cti@...d000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x0801d000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti14: cti@...e000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x0801e000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		cti15: cti@...f000 {
> +			compatible = "arm,coresight-cti", "arm,primecell";
> +			reg = <0x0801f000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +		};
> +
> +		replicator@...6000 {
> +			compatible = "arm,coresight-dynamic-replicator", "arm,primecell";
> +			reg = <0x08046000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					replicator_out: endpoint {
> +						remote-endpoint = <&etr_in>;
> +					};
> +				};
> +			};
> +
> +			in-ports {
> +				port {
> +					replicator_in: endpoint {
> +						remote-endpoint = <&etf_out>;
> +					};
> +				};
> +			};
> +		};
> +
> +		etf@...7000 {
> +			compatible = "arm,coresight-tmc", "arm,primecell";
> +			reg = <0x08047000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +
> +			in-ports {
> +				port {
> +					etf_in: endpoint {
> +						remote-endpoint = <&merge_funnel_out>;
> +					};
> +				};
> +			};
> +
> +			out-ports {
> +				port {
> +					etf_out: endpoint {
> +						remote-endpoint = <&replicator_in>;
> +					};
> +				};
> +			};
> +		};
> +
> +		etr@...8000 {
> +			compatible = "arm,coresight-tmc", "arm,primecell";
> +			reg = <0x08048000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +
> +			in-ports {
> +				port {
> +					etr_in: endpoint {
> +						remote-endpoint = <&replicator_out>;
> +					};
> +				};
> +			};
> +		};
> +
> +		stm@...2000 {
This one node is out of order

I *think* the rest looks good overall... so:

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
> +			compatible = "arm,coresight-stm", "arm,primecell";
> +			reg = <0x08002000 0x1000>,
> +			      <0x0e280000 0x180000>;
> +			reg-names = "stm-base", "stm-stimulus-base";
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					stm_out: endpoint {
> +						remote-endpoint = <&funnel_in0_in>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...1000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +			reg = <0x08041000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					funnel_in0_out: endpoint {
> +						remote-endpoint = <&merge_funnel_in0>;
> +					};
> +				};
> +			};
> +
> +			in-ports {
> +				port {
> +					funnel_in0_in: endpoint {
> +						remote-endpoint = <&stm_out>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...2000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +			reg = <0x08042000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					funnel_in1_out: endpoint {
> +						remote-endpoint = <&merge_funnel_in1>;
> +					};
> +				};
> +			};
> +
> +			in-ports {
> +				port {
> +					funnel_in1_in: endpoint {
> +						remote-endpoint = <&funnel_apss1_out>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...5000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +			reg = <0x08045000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					merge_funnel_out: endpoint {
> +						remote-endpoint = <&etf_in>;
> +					};
> +				};
> +			};
> +
> +			in-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					merge_funnel_in0: endpoint {
> +						remote-endpoint = <&funnel_in0_out>;
> +					};
> +				};
> +
> +				port@1 {
> +					reg = <1>;
> +					merge_funnel_in1: endpoint {
> +						remote-endpoint = <&funnel_in1_out>;
> +					};
> +				};
> +			};
> +		};
> +
> +		etm@...0000 {
> +			compatible = "arm,coresight-etm4x", "arm,primecell";
> +			reg = <0x09040000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +			arm,coresight-loses-context-with-cpu;
> +
> +			cpu = <&CPU0>;
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					etm0_out: endpoint {
> +						remote-endpoint = <&funnel_apss0_in0>;
> +					};
> +				};
> +			};
> +		};
> +
> +		etm@...0000 {
> +			compatible = "arm,coresight-etm4x", "arm,primecell";
> +			reg = <0x09140000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +			arm,coresight-loses-context-with-cpu;
> +
> +			cpu = <&CPU1>;
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					etm1_out: endpoint {
> +						remote-endpoint = <&funnel_apss0_in1>;
> +					};
> +				};
> +			};
> +		};
> +
> +		etm@...0000 {
> +			compatible = "arm,coresight-etm4x", "arm,primecell";
> +			reg = <0x09240000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +			arm,coresight-loses-context-with-cpu;
> +
> +			cpu = <&CPU2>;
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					etm2_out: endpoint {
> +						remote-endpoint = <&funnel_apss0_in2>;
> +					};
> +				};
> +			};
> +		};
> +
> +		etm@...0000 {
> +			compatible = "arm,coresight-etm4x", "arm,primecell";
> +			reg = <0x09340000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +			arm,coresight-loses-context-with-cpu;
> +
> +			cpu = <&CPU3>;
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					etm3_out: endpoint {
> +						remote-endpoint = <&funnel_apss0_in3>;
> +					};
> +				};
> +			};
> +		};
> +
> +		etm@...0000 {
> +			compatible = "arm,coresight-etm4x", "arm,primecell";
> +			reg = <0x09440000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +			arm,coresight-loses-context-with-cpu;
> +
> +			cpu = <&CPU4>;
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					etm4_out: endpoint {
> +						remote-endpoint = <&funnel_apss0_in4>;
> +					};
> +				};
> +			};
> +		};
> +
> +		etm@...0000 {
> +			compatible = "arm,coresight-etm4x", "arm,primecell";
> +			reg = <0x09540000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +			arm,coresight-loses-context-with-cpu;
> +
> +			cpu = <&CPU5>;
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					etm5_out: endpoint {
> +						remote-endpoint = <&funnel_apss0_in5>;
> +					};
> +				};
> +			};
> +		};
> +
> +		etm@...0000 {
> +			compatible = "arm,coresight-etm4x", "arm,primecell";
> +			reg = <0x09640000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +			arm,coresight-loses-context-with-cpu;
> +
> +			cpu = <&CPU6>;
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					etm6_out: endpoint {
> +						remote-endpoint = <&funnel_apss0_in6>;
> +					};
> +				};
> +			};
> +		};
> +
> +		etm@...0000 {
> +			compatible = "arm,coresight-etm4x", "arm,primecell";
> +			reg = <0x09740000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +			arm,coresight-loses-context-with-cpu;
> +
> +			cpu = <&CPU7>;
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					etm7_out: endpoint {
> +						remote-endpoint = <&funnel_apss0_in7>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...0000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +			reg = <0x09800000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					funnel_apss0_out: endpoint {
> +						remote-endpoint = <&funnel_apss1_in>;
> +					};
> +				};
> +			};
> +
> +			in-ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					funnel_apss0_in0: endpoint {
> +						remote-endpoint = <&etm0_out>;
> +					};
> +				};
> +
> +				port@1 {
> +					reg = <1>;
> +					funnel_apss0_in1: endpoint {
> +						remote-endpoint = <&etm1_out>;
> +					};
> +				};
> +
> +				port@2 {
> +					reg = <2>;
> +					funnel_apss0_in2: endpoint {
> +						remote-endpoint = <&etm2_out>;
> +					};
> +				};
> +
> +				port@3 {
> +					reg = <3>;
> +					funnel_apss0_in3: endpoint {
> +						remote-endpoint = <&etm3_out>;
> +					};
> +				};
> +
> +				port@4 {
> +					reg = <4>;
> +					funnel_apss0_in4: endpoint {
> +						remote-endpoint = <&etm4_out>;
> +					};
> +				};
> +
> +				port@5 {
> +					reg = <5>;
> +					funnel_apss0_in5: endpoint {
> +						remote-endpoint = <&etm5_out>;
> +					};
> +				};
> +
> +				port@6 {
> +					reg = <6>;
> +					funnel_apss0_in6: endpoint {
> +						remote-endpoint = <&etm6_out>;
> +					};
> +				};
> +
> +				port@7 {
> +					reg = <7>;
> +					funnel_apss0_in7: endpoint {
> +						remote-endpoint = <&etm7_out>;
> +					};
> +				};
> +			};
> +		};
> +
> +		funnel@...0000 {
> +			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> +			reg = <0x09810000 0x1000>;
> +
> +			clocks = <&rpmcc RPM_SMD_QDSS_CLK>;
> +			clock-names = "apb_pclk";
> +
> +			status = "disabled";
> +
> +			out-ports {
> +				port {
> +					funnel_apss1_out: endpoint {
> +						remote-endpoint = <&funnel_in1_in>;
> +					};
> +				};
> +			};
> +
> +			in-ports {
> +				port {
> +					funnel_apss1_in: endpoint {
> +						remote-endpoint = <&funnel_apss0_out>;
> +					};
> +				};
> +			};
> +		};
> +
>  		apps_smmu: iommu@...0000 {
>  			compatible = "qcom,sm6115-smmu-500", "qcom,smmu-500", "arm,mmu-500";
>  			reg = <0x0c600000 0x80000>;

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ