linux-kernel - Re: [RESEND PATCH V3 2/3] arm64: dts: ti: Add initial support for AM68 SK System on Module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e06a7758-1245-4353-7d62-fd6dc40b3164@ti.com>
Date:   Sun, 15 Jan 2023 17:48:52 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Sinthu Raja M <sinthu.raja@...tralsolutions.com>,
        Vaishnav Achath <vaishnav.a@...com>
CC:     Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Sinthu Raja <sinthu.raja@...com>
Subject: Re: [RESEND PATCH V3 2/3] arm64: dts: ti: Add initial support for
 AM68 SK System on Module

Hi Sinthu,

On 13/01/23 5:56 pm, Sinthu Raja M wrote:
>>> +     reserved_memory: reserved-memory {
>>> +             #address-cells = <2>;
>>> +             #size-cells = <2>;
>>> +             ranges;
>>> +
>>> +             secure_ddr: optee@...00000 {
>>> +                     reg = <0x00 0x9e800000 0x00 0x01800000>;
>>> +                     alignment = <0x1000>;
>> Is alignment needed here?
> This is used to mention the address boundary. Removing this will
> affect memory allocation. Isn't so?

No memory is allocated out of this region. This is reserved region where
OPTEE runs and thus ought not to be touched by Linux. Please drop the
property.

>>
>> Please see https://lore.kernel.org/lkml/cd5dbbb0-2d9f-8d7d-b051-f8d01d710c62@ti.com/
>>
>>> +                     no-map;
>>> +             };
>>> +     };
>>> +};
>> --
>> Regards,
>> Vaishnav

Regards
Vignesh