linux-kernel - [PATCH v1] mm: multi-gen LRU: reduce repeated scans in rmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230115125721.3553-1-tjytimi@163.com>
Date:   Sun, 15 Jan 2023 20:57:21 +0800
From:   Jinyu Tang <tjytimi@....com>
To:     yuzhao@...gle.com, yuanchu@...gle.com
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, falcon@...ylab.org,
        ttjjyystupid@....com, Jinyu Tang <tjytimi@....com>
Subject: [PATCH v1] mm: multi-gen LRU: reduce repeated scans in rmap

The folio is physically and virtually contiguous. If a folio have
more than one pages, lru_gen_look_around() will run several times in
the while loop in folio_referenced_one(), but most of times is
unnecessary. Because these pages always belong to the same pmd and
vma, lru_gen_look_around() will scan the same range.

So add a variable to record the former pvmw.address to reduce
repeated scans if the pages of this folio don't sride across a pmd.

In most codes in memory management now, a folio just have one page,
the while loop in folio_referenced_one() just run one time, so this
patch actually may not reduce scans. But when other memory management
codes expand contiguous pages to a folio in the future, this patch
can be more effective.

Signed-off-by: Jinyu Tang <tjytimi@....com>
---
 mm/rmap.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/mm/rmap.c b/mm/rmap.c
index 2ec925e5fa6a..b11fcfe812e8 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -809,6 +809,7 @@ static bool folio_referenced_one(struct folio *folio,
 	struct folio_referenced_arg *pra = arg;
 	DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, address, 0);
 	int referenced = 0;
+	unsigned long former_address = 0;

 	while (page_vma_mapped_walk(&pvmw)) {
 		address = pvmw.address;
@@ -825,7 +826,13 @@ static bool folio_referenced_one(struct folio *folio,
 		if (pvmw.pte) {
 			if (lru_gen_enabled() && pte_young(*pvmw.pte) &&
 			    !(vma->vm_flags & (VM_SEQ_READ | VM_RAND_READ))) {
-				lru_gen_look_around(&pvmw);
+				unsigned long pmd_now = pvmw.address & PMD_MASK;
+				unsigned long pmd_former = former_address & PMD_MASK;
+
+				if ((!former_address) || (pmd_now != pmd_former)) {
+					lru_gen_look_around(&pvmw);
+					former_address = pvmw.address;
+				}
 				referenced++;
 			}

-- 
2.30.2