linux-kernel - Re: [PATCH v1] Asoc: dt_bindings: Add tas2781 yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3d5b577-2810-7ce1-3136-b0bc6c9171a5@linaro.org>
Date:   Sun, 15 Jan 2023 15:24:43 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Kevin Lu <luminlong@....com>, lgirdwood@...il.com,
        broonie@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Cc:     alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, shenghao-ding@...com,
        kevin-lu@...com, navada@...com, peeyush@...com
Subject: Re: [PATCH v1] Asoc: dt_bindings: Add tas2781 yaml

On 15/01/2023 13:16, Kevin Lu wrote:
> Complete the DTS for tas2781

1. This is not a v1 but v2.
2. Subject - still wrong.
3. Commit msg - does not make sense to me. I don't understand it.
4. Other comments - also not implemented.

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.

Thank you.



> 
> Signed-off-by: Kevin Lu <luminlong@....com>
> ---
>  .../devicetree/bindings/sound/ti,tas2781.yaml | 122 ++++++++++++++++++
>  1 file changed, 122 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> new file mode 100644
> index 0000000..7d73f46
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> @@ -0,0 +1,122 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2022 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/ti,tas2781.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TAS2781 Smart PA
> +
> +maintainers:
> +  - Shenghao Ding <shenghao-ding@...com>
> +  - Kevin Lu <kevin-lu@...com>
> +
> +description: |
> +  The TAS2781 is a mono, digital input Class-D audio amplifier
> +  optimized for efficiently driving high peak power into small
> +  loudspeakers. Integrated an on-chip DSP supports Texas Instruments
> +  Smart Amp speaker protection algorithm. The integrated speaker
> +  voltage and current sense provides for real time
> +  monitoring of loudspeaker behavior.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tas2781
> +
> +  reg:
> +    maxItems: 1
> +    description: |
> +      I2C address of the device can be in range from 0x38 to 0x40.
> +
> +  ti,audio-slots:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    minItems: 1
> +    maxItems: 4
> +    description: |
> +      This item is used to store the i2c address of the device
> +      for deifferent audio slots. It is not required for Mono case.
> +
> +  ti,global-addr:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      This item is used to store the generic i2c address of
> +      all the tas2781 devices for I2C broadcast during the multi-device
> +      writes, useless in mono case.
> +
> +  ti,reset-gpios:

I asked you to use existing property. Drop prefix.

> +    minItems: 1
> +    maxItems: 4
> +    description: GPIO specifier for the reset pin.
> +
> +  ti,irq-gpio:
> +    maxItems: 1
> +    description: GPIO used to interrupts the device.

So you ignored around 3 or four my comments. I'll stop the review - it
does not make sense.

NAK - this is not correct property. Implement the feedback.

Best regards,
Krzysztof