linux-kernel - Re: [PATCH v3 2/2] dt-bindings: iio: adc: add Texas Instruments ADS7924

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e30a869a-5585-901b-6a56-3e327e0cf60a@linaro.org>
Date:   Sun, 15 Jan 2023 20:17:24 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Hugo Villeneuve <hugo@...ovil.com>,
        Jonathan Cameron <jic23@...nel.org>
Cc:     hvilleneuve@...onoff.com, lars@...afoo.de, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: adc: add Texas Instruments
 ADS7924

On 15/01/2023 17:32, Hugo Villeneuve wrote:
>>>>> +    required:
>>>>> +      - reg
>>>>> +
>>>>> +    additionalProperties: false  
>>>>
>>>> You are not allowing anything else from adc.yaml. Is it on purpose?  
>>>
>>> I am really not an expert with this Yaml stuff, and reading the documentation makes me probably more confused than before reading it :)
>>>
>>> But one thing that is for sure is that these other properties in adc.yaml are not used in my driver:
>>>
>>>   bipolar
>>>   diff-channels
>>>   settling-time-us
>>>   oversampling-ratio
>>>
>>> So is it Ok then to use "additionalProperties: false"? I think so, but what is your recommandation?
>>
>> Makes sense to me.  Whilst there are lots of things a channel can support, most
>> of them are hardware related and not universal.
> 
> Ok, I think I am finally beginning to see the light here :)
> 
> So I will then leave "additionalProperties: false".
> 
> I will send a V4 soon with all the latest changes.
> 

Just to clarify - we talk about hardware, not your Linux driver. What
your driver uses or doesn't, should not matter here that much.

Best regards,
Krzysztof