linux-kernel - Re: [PATCH] btrfs: raid56: Fix stripes if vertical errors are found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e103b9fb-9d73-efb5-2f70-9537e943fad0@gmx.com>
Date:   Mon, 16 Jan 2023 07:37:50 +0800
From:   Qu Wenruo <quwenruo.btrfs@....com>
To:     Tanmay Bhushan <007047221b@...il.com>, Chris Mason <clm@...com>,
        Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: raid56: Fix stripes if vertical errors are found



On 2023/1/16 04:32, Tanmay Bhushan wrote:
> We take two stripe numbers if vertical errors are found.
> In case it is just a pstripe it does not matter but in
> case of raid 6 it matters a both stripes need to be fixed.
> 
> Signed-off-by: Tanmay Bhushan <007047221b@...il.com>

Oh, my bad, typical copy-and-paste error.

Should go in to the next rc.

Fixes: 7a3150723061 ("btrfs: raid56: do data csum verification during 
RMW cycle")

Thanks,
Qu
> ---
>   fs/btrfs/raid56.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
> index 6a2cf754912d..f35898a78b16 100644
> --- a/fs/btrfs/raid56.c
> +++ b/fs/btrfs/raid56.c
> @@ -1886,7 +1886,7 @@ static int recover_vertical(struct btrfs_raid_bio *rbio, int sector_nr,
>   		sector->uptodate = 1;
>   	}
>   	if (failb >= 0) {
> -		ret = verify_one_sector(rbio, faila, sector_nr);
> +		ret = verify_one_sector(rbio, failb, sector_nr);
>   		if (ret < 0)
>   			goto cleanup;
>