linux-kernel - Re: [PATCH 5.10 1/1] block: fix and cleanup bio_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8OzlLXW4WvgvwDw@kroah.com>
Date:   Sun, 15 Jan 2023 09:04:36 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Fedor Pchelkin <pchelkin@...ras.ru>
Cc:     stable@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        Christoph Hellwig <hch@....de>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Johannes Thumshirn <johannes.thumshirn@....com>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH 5.10 1/1] block: fix and cleanup bio_check_ro

On Sun, Jan 15, 2023 at 01:27:09AM +0300, Fedor Pchelkin wrote:
> From: Christoph Hellwig <hch@....de>
> 
> commit 57e95e4670d1126c103305bcf34a9442f49f6d6a upstream.
> 
> Don't use a WARN_ONCE when printing a potentially user triggered
> condition.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>
> Link: https://lore.kernel.org/r/20220304180105.409765-2-hch@lst.de
> Signed-off-by: Jens Axboe <axboe@...nel.dk>
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>
> ---
>  block/blk-core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 26664f2a139e..921d436fa3c6 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -701,8 +701,7 @@ static inline bool bio_check_ro(struct bio *bio, struct hd_struct *part)
>  		if (op_is_flush(bio->bi_opf) && !bio_sectors(bio))
>  			return false;
>  
> -		WARN_ONCE(1,
> -		       "Trying to write to read-only block-device %s (partno %d)\n",
> +		pr_warn("Trying to write to read-only block-device %s (partno %d)\n",
>  			bio_devname(bio, b), part->partno);
>  		/* Older lvm-tools actually trigger this */
>  		return false;
> -- 
> 2.34.1
> 

Again, we CAN NOT take patches for older kernels and not for newer ones,
that one will cause regressions when people upgrade to newer kernels.

So I'm dropping all of your patches from my queue, please resend them so
that all trees are properly covered.  As-is, I can not take the, and
most importantly, you do not want me to accept such a thing!

thanks,

greg k-h