linux-kernel - Re: [PATCH 3/3] rust: arch/um: Add support for CONFIG_RUST under x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA76j91c1Uxo04Ymg8HszPOmiMjCzC08iDGL05m1ABa+u_Pw1A@mail.gmail.com>
Date:   Sun, 15 Jan 2023 10:49:37 +0100
From:   Sergio González Collado <sergio.collado@...il.com>
To:     David Gow <davidgow@...gle.com>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Richard Weinberger <richard@....at>,
        Anton Ivanov <anton.ivanov@...bridgegreys.com>,
        Johannes Berg <johannes@...solutions.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        rust-for-linux@...r.kernel.org, linux-um@...ts.infradead.org,
        llvm@...ts.linux.dev, linux-doc@...r.kernel.org,
        kunit-dev@...glegroups.com, x86@...nel.org,
        linux-kernel@...r.kernel.org,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Gary Guo <gary@...yguo.net>,
        Brendan Higgins <brendan.higgins@...ux.dev>,
        Daniel Latypov <dlatypov@...gle.com>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH 3/3] rust: arch/um: Add support for CONFIG_RUST under
 x86_64 UML

On Sat, 17 Dec 2022 at 05:48, David Gow <davidgow@...gle.com> wrote:
>
> CONFIG_RUST currently supports x86_64, but does not support it under
> UML. With the previous patches applied, adding support is trivial:
> add CONFIG_HAVE_RUST to UML if X86_64 is set.
>
> The scripts/generate_rust_target.rs file already checks for
> CONFIG_X86_64, not CONFIG_X86, so is prepared for UML support.
>
> The Rust support does not currently support X86_32.
>
> Also, update the Rust architecture support documentation to not that
> this is being maintained: I intend to look after this as best I can.
>
> Signed-off-by: David Gow <davidgow@...gle.com>
> ---
>  Documentation/rust/arch-support.rst | 2 ++
>  arch/um/Kconfig                     | 1 +
>  2 files changed, 3 insertions(+)
>
> diff --git a/Documentation/rust/arch-support.rst b/Documentation/rust/arch-support.rst
> index 6982b63775da..a526ca1c688b 100644
> --- a/Documentation/rust/arch-support.rst
> +++ b/Documentation/rust/arch-support.rst
> @@ -17,3 +17,5 @@ Architecture  Level of support  Constraints
>  ============  ================  ==============================================
>  ``x86``       Maintained        ``x86_64`` only.
>  ============  ================  ==============================================
> +``um``        Maintained        ``x86_64`` only.
> +============  ================  ==============================================
> diff --git a/arch/um/Kconfig b/arch/um/Kconfig
> index ad4ff3b0e91e..4db186f019ae 100644
> --- a/arch/um/Kconfig
> +++ b/arch/um/Kconfig
> @@ -28,6 +28,7 @@ config UML
>         select TRACE_IRQFLAGS_SUPPORT
>         select TTY # Needed for line.c
>         select HAVE_ARCH_VMAP_STACK
> +       select HAVE_RUST                        if X86_64
>
>  config MMU
>         bool
> --
> 2.39.0.314.g84b9a713c41-goog
>

Reviewed-by: Sergio González Collado <sergio.collado@...il.com>