linux-kernel - Re: [PATCH] infiniband: sw: rxe: Add NULL checks for qp->resp.mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8Ps7UgTUuNx/+Qz@unreal>
Date:   Sun, 15 Jan 2023 14:09:17 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Zhu Yanjun <yanjun.zhu@...ux.dev>
Cc:     Jia-Ju Bai <baijiaju1990@...il.com>, zyjzyj2000@...il.com,
        jgg@...pe.ca, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, TOTE Robot <oslab@...nghua.edu.cn>
Subject: Re: [PATCH] infiniband: sw: rxe: Add NULL checks for qp->resp.mr

On Fri, Jan 13, 2023 at 03:53:46PM +0800, Zhu Yanjun wrote:
> 在 2023/1/13 10:35, Jia-Ju Bai 写道:
> > In a previous commit 3282a549cf9b, qp->resp.mr could be NULL. Moreover,
> > in many functions, qp->resp.mr is checked before its dereferences.
> > However, in some functions, this variable is not checked, and thus NULL
> > checks should be added.
> 
> IMO， we should analyze the code snippet one by one.
> And it is not good to add "NULL check" without futher investigations.

+1