[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230116155545.101391-1-jonathanh@nvidia.com>
Date: Mon, 16 Jan 2023 15:55:44 +0000
From: Jon Hunter <jonathanh@...dia.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-tegra@...r.kernel.org>,
Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
Jon Hunter <jonathanh@...dia.com>
Subject: [PATCH V2 1/2] usb: gadget: u_ether: Improve print in gether_setup_name_default()
The print in in gether_setup_name_default() does not provide any useful
information because a random MAC address will always be generated when
calling this function. Rather than removing the print, update the print
to show MAC address that is generated which is similar to other ethernet
drivers.
Finally, given that the strings 'self' and 'host' are static we do not
need to pass these strings as an arguments.
Signed-off-by: Jon Hunter <jonathanh@...dia.com>
---
V1 -> V2: Added this patch
drivers/usb/gadget/function/u_ether.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index 8f12f3f8f6ee..be8e7b448933 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -845,13 +845,13 @@ struct net_device *gether_setup_name_default(const char *netname)
snprintf(net->name, sizeof(net->name), "%s%%d", netname);
eth_random_addr(dev->dev_mac);
- pr_warn("using random %s ethernet address\n", "self");
+ pr_warn("using random self ethernet address %pM\n", dev->dev_mac);
/* by default we always have a random MAC address */
net->addr_assign_type = NET_ADDR_RANDOM;
eth_random_addr(dev->host_mac);
- pr_warn("using random %s ethernet address\n", "host");
+ pr_warn("using random host ethernet address %pM\n", dev->host_mac);
net->netdev_ops = ð_netdev_ops;
--
2.25.1
Powered by blists - more mailing lists