linux-kernel - Re: Is there a reason why REQ_OP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8V1n4e/eeOd4n8/@infradead.org>
Date:   Mon, 16 Jan 2023 08:04:47 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Christoph Hellwig <hch@...radead.org>,
        linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Is there a reason why REQ_OP_READ has to be 0?

On Mon, Jan 16, 2023 at 04:01:50PM +0000, David Howells wrote:
> Hi Jens, Christoph,
> 
> Do you know if there's a reason why REQ_OP_READ has to be 0?  I'm seeing a
> circumstance where a direct I/O write on a blockdev is BUG'ing in my modified
> iov_iter code because the iterator says it's a source iterator (correct), but
> the bio->bi_opf == REQ_OP_READ (which should be wrong).
> 
> I thought I'd move REQ_OP_READ to, say, 4 so that I could try and see if it's
> just undefined but the kernel BUGs and then panics during boot.

There's all kind of assumptions of that from basically day 1 of
Linux.  The most obvious one is in op_is_write, but I'm pretty sure
there are more hidden somewhere.