linux-kernel - Re: [PATCH] block: check disk flag before setting scan bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <05a28cc6-0070-9117-368e-ade7561f6727@kernel.dk>
Date:   Mon, 16 Jan 2023 09:14:55 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     wangjie <wangjie22@...iang.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: check disk flag before setting scan bit

On 1/16/23 1:38?AM, wangjie wrote:
> No need to scan partitions for disk who has set flag GENHD_FL_NO_PART in
> driver code. In disk_scan_partitions function, the same checking is
> existing, so we believe this change is reasonable.
> 
> In our case, some virtual block devices are not managed by GPT, then scan
> partition operation is not a must. So we set GENHD_FL_NO_PART flag in
> driver intended to avoid partitions being dropped/added.
> But GD_NEED_PART_SCAN bit was still set by bdev_check_media_change, which
> causing problems here.
> 
> Signed-off-by: wangjie

Signed-off-by is in the wrong format, and the whole email is badly
mangled...

> ????????????????????????????????????????????????????
> ????????????????????????????????????????????????????
> ???????????????????????????????

This didn't quote well, but the original is also useless. You do realize
you send this email to a public list? Please get rid of it.

-- 
Jens Axboe