linux-kernel - Re: [PATCH] gpio: omap: use dynamic allocation of base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8WF2gXbrGnDLQ+S@atomide.com>
Date:   Mon, 16 Jan 2023 19:14:02 +0200
From:   Tony Lindgren <tony@...mide.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Andreas Kemnade <andreas@...nade.info>, grygorii.strashko@...com,
        ssantosh@...nel.org, khilman@...nel.org, linus.walleij@...aro.org,
        linux-omap@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: omap: use dynamic allocation of base

* Bartosz Golaszewski <brgl@...ev.pl> [230116 08:38]:
> On Fri, Jan 13, 2023 at 9:59 PM Andreas Kemnade <andreas@...nade.info> wrote:
> > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> > index 80ddc43fd875..f5f3d4b22452 100644
> > --- a/drivers/gpio/gpio-omap.c
> > +++ b/drivers/gpio/gpio-omap.c
> > @@ -1020,7 +1020,7 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct irq_chip *irqc,
> >                 if (!label)
> >                         return -ENOMEM;
> >                 bank->chip.label = label;
> > -               bank->chip.base = gpio;
> > +               bank->chip.base = -1;
> >         }
> >         bank->chip.ngpio = bank->width;
> >
> > --
> > 2.30.2
> >
> 
> This could potentially break some legacy user-space programs using
> sysfs but whatever, let's apply it and see if anyone complains.

Worth a try for sure, fingers crossed. I guess /sys/class/gpio will
break at least.

Regards,

Tony