linux-kernel - Re: [PATCH mm v2] mm: hugetlb: Add checks for NULL for vma returned from find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8WXsOaR+pclaUNp@monkey>
Date:   Mon, 16 Jan 2023 10:30:08 -0800
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Esina Ekaterina <eesina@...ralinux.ru>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH mm v2] mm: hugetlb: Add checks for NULL for vma returned
 from find_vma.

On 01/16/23 13:39, Esina Ekaterina wrote:
> find_vma may return NULL, that's why its return value
>  is usually checked for NULL. vma should be checked before dereferencing 
> 
> Found by Astra Linux on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Esina Ekaterina <eesina@...ralinux.ru>
> ---
>  mm/hugetlb.c | 32 ++++++++++++++++++--------------
>  1 file changed, 18 insertions(+), 14 deletions(-)

This is not the latest version of the code.  What version are you
targeting?

I would claim that find_vma() can not return NULL in previous versions
of the code which this patch seems to target.  Why?  This routine is
called with mmap sema held and we know addr is part of the vma. 
-- 
Mike Kravetz