linux-kernel - Re: [PATCH v3] USB: serial: option: add Quectel EM05CN (SG) modem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8UCeOZovGzr+cK8@hovoldconsulting.com>
Date:   Mon, 16 Jan 2023 08:53:28 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Duke Xin(辛安文) <duke_xinanwen@....com>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, jerry.meng@...ctel.com,
        duke.xin@...ctel.com
Subject: Re: [PATCH v3] USB: serial: option: add Quectel EM05CN (SG) modem

On Sun, Jan 15, 2023 at 06:07:27PM -0800, Duke Xin(辛安文) wrote:
> The EM05CN (SG) modem has 2 USB configurations that are configurable via the AT
> command AT+QCFG="usbnet",[ 0 | 2 ] which make the modem enumerate with
> the following interfaces, respectively:
> 
> "MBIM"  : AT + MBIM + DIAG + NMEA  + MODEM
> "RMNET" : AT + DIAG + NMEA + Modem + QMI
> 
> The detailed description of the USB configuration for each mode as follows:

> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@....com>
> ---

Thanks for the update. Patch itself looks good, but you forgot to
include a short changelog here below the --- line.

I've applied both v3 patches now so no need to send a v4 for this, but
please try to remember this for your future contributions.

Johan