linux-kernel - Re: [PATCH 01/10] dt-bindings: media: mediatek,vcodec: Remove dma-ranges property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 16 Jan 2023 08:01:29 +0000
From:   Yong Wu (吴勇) <Yong.Wu@...iatek.com>
To:     "joro@...tes.org" <joro@...tes.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
CC:     Andrew-CT Chen (陳智迪) 
        <Andrew-CT.Chen@...iatek.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Youlin Pei (裴友林) 
        <youlin.pei@...iatek.com>,
        Tiffany Lin (林慧珊) 
        <tiffany.lin@...iatek.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Anan Sun (孙安安) <Anan.Sun@...iatek.com>,
        Libo Kang (康利波) <Libo.Kang@...iatek.com>,
        "kyrie.wu@...iatek.corp-partner.google.com" 
        <kyrie.wu@...iatek.corp-partner.google.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "hverkuil@...all.nl" <hverkuil@...all.nl>,
        Chengci Xu (许承赐) 
        <Chengci.Xu@...iatek.com>,
        Yunfei Dong (董云飞) 
        <Yunfei.Dong@...iatek.com>,
        YF Wang (王云飞) <YF.Wang@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        Mingyuan Ma (马鸣远) 
        <Mingyuan.Ma@...iatek.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "will@...nel.org" <will@...nel.org>,
        "nfraprado@...labora.com" <nfraprado@...labora.com>
Subject: Re: [PATCH 01/10] dt-bindings: media: mediatek,vcodec: Remove
 dma-ranges property

On Fri, 2023-01-13 at 09:25 +0100, Krzysztof Kozlowski wrote:
> On 13/01/2023 07:01, Yong Wu wrote:
> > MediaTek iommu has already controlled the masters' iova ranges by
> > the
> > master's larb/port id. then the dma-ranges property is unnecessary
> > for

> Sentences in English always start with a capital letter, however also
> they do not start with "Then". Make it a proper a proper sentence.

Sorry for the syntax issues. I think it is "," before "then".

> > the master's node. the master is vcodec here.
> 
> Unnecessary or invalid? 

For mt8195, It is unnecessary. For the other SoC which doesn't use
parent/child node, the property is invalid, however, there is no vcodec
node have this property in this case in the current upstream dts nodes.

> Don't you depend now on some feature of driver
> added for example recently?

No. It doesn't depend on any the other patches. Just depend
on the code changing in this patchset. I just put the dt-binding
at the beginning of this series.

> > 
> > Cc: Tiffany Lin <tiffany.lin@...iatek.com>
> > Cc: Andrew-CT Chen <andrew-ct.chen@...iatek.com>
> > Cc: Yunfei Dong <yunfei.dong@...iatek.com>
> > Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> > Cc: Rob Herring <robh+dt@...nel.org>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> 
> There is little point in storing output of get_maintainers.pl forever
> in
> the git log. If you need it for some reason, please keep it after -
> --.

I did get the list from get_maintainers.pl. Sorry that I didn't
differentiate.

Mainly I changed the iommu code but changed the media dt-binding.
Just expect the media owners/reviewers to take a look at this.

Thanks.

> > Cc: Matthias Brugger <matthias.bgg@...il.com>
> > Signed-off-by: Yong Wu <yong.wu@...iatek.com>
> > ---
> >  .../devicetree/bindings/media/mediatek,vcodec-decoder.yaml | 5 -
> > ----
> >  .../devicetree/bindings/media/mediatek,vcodec-encoder.yaml | 5 -
> > ----
> >  .../bindings/media/mediatek,vcodec-subdev-decoder.yaml     | 7 -
> > ------
> >  3 files changed, 17 deletions(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > decoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > decoder.yaml
> > index aa55ca65d6ed..fad59b486d5d 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > decoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > decoder.yaml
> > @@ -56,11 +56,6 @@ properties:
> >        List of the hardware port in respective IOMMU block for
> > current Socs.
> >        Refer to bindings/iommu/mediatek,iommu.yaml.
> >  
> > -  dma-ranges:
> > -    maxItems: 1
> > -    description: |
> > -      Describes the physical address space of IOMMU maps to
> > memory.
> > -
> >    mediatek,vpu:
> >      $ref: /schemas/types.yaml#/definitions/phandle
> >      description:
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > index 0f2ea8d9a10c..a2051b31fa29 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > encoder.yaml
> > @@ -49,11 +49,6 @@ properties:
> >        List of the hardware port in respective IOMMU block for
> > current Socs.
> >        Refer to bindings/iommu/mediatek,iommu.yaml.
> >  
> > -  dma-ranges:
> > -    maxItems: 1
> > -    description: |
> > -      Describes the physical address space of IOMMU maps to
> > memory.
> > -
> >    mediatek,vpu:
> >      $ref: /schemas/types.yaml#/definitions/phandle
> >      description:
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > index c4f20acdc1f8..290594bc91cc 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > @@ -76,11 +76,6 @@ properties:
> >        The node of system control processor (SCP), using
> >        the remoteproc & rpmsg framework.
> >  
> > -  dma-ranges:
> > -    maxItems: 1
> > -    description: |
> > -      Describes the physical address space of IOMMU maps to
> > memory.
> > -
> >    "#address-cells":
> >      const: 2
> >  
> > @@ -203,7 +198,6 @@ required:
> >    - reg
> >    - iommus
> >    - mediatek,scp
> > -  - dma-ranges
> >    - ranges
> >  
> >  if:
> > @@ -236,7 +230,6 @@ examples:
> >              compatible = "mediatek,mt8192-vcodec-dec";
> >              mediatek,scp = <&scp>;
> >              iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>;
> > -            dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 0xfff00000>;
> >              #address-cells = <2>;
> >              #size-cells = <2>;
> >              ranges = <0 0 0 0x16000000 0 0x40000>;
> 
> Best regards,
> Krzysztof
> 
>