linux-kernel - Re: [patch V3 16/22] genirq/msi: Provide new domain id based interfaces for freeing interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad1dfa58888f82d7cf6fd1b86d2df3821511cf33.camel@infradead.org>
Date:   Mon, 16 Jan 2023 10:10:39 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Juergen Gross <jgross@...e.com>,
        xen-devel <xen-devel@...ts.xen.org>
Cc:     x86@...nel.org, Joerg Roedel <joro@...tes.org>,
        Will Deacon <will@...nel.org>, linux-pci@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Marc Zyngier <maz@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jason Gunthorpe <jgg@...lanox.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        Ashok Raj <ashok.raj@...el.com>, Jon Mason <jdmason@...zu.us>,
        Allen Hubbe <allenbh@...il.com>
Subject: Re: [patch V3 16/22] genirq/msi: Provide new domain id based
 interfaces for freeing interrupts

On Mon, 2023-01-16 at 09:56 +0000, David Woodhouse wrote:
> 
>  	msi_for_each_desc(msidesc, &dev->dev, MSI_DESC_ASSOCIATED) {
> -		for (i = 0; i < msidesc->nvec_used; i++)
> +		for (i = 0; i < msidesc->nvec_used; i++) {
>  			xen_destroy_irq(msidesc->irq + i);
> +			msidesc->irq = 0;
> +		}
>  	}
>  }
>  

Der, setting it to zero wants to be in the msi_for_each_desc() loop and
*not* in the 'for i' loop of course.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)