linux-kernel - Re: [PATCH -next 7/7] mm: swap: remove unneeded cgroup_throttle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <715cfcd3-47c3-f7f4-7dd1-4d76c6b147f8@huawei.com>
Date:   Mon, 16 Jan 2023 19:37:37 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next 7/7] mm: swap: remove unneeded
 cgroup_throttle_swaprate()

Hi Matthew,

On 2023/1/13 23:50, Matthew Wilcox wrote:
> On Thu, Jan 12, 2023 at 04:30:06PM +0800, Kefeng Wang wrote:
>> All the callers of cgroup_throttle_swaprate() are converted to
>> folio_throttle_swaprate(), so make __cgroup_throttle_swaprate()
>> to take a folio, and drop unused cgroup_throttle_swaprate().
> 
> Shouldn't __cgroup_throttle_swaprate() then be called
> __folio_throttle_swaprate()?

Sure.

> 
>> +extern void __cgroup_throttle_swaprate(struct folio *folio, gfp_t gfp_mask);
> 
> Also you can drop the 'extern'.

Ok.

> 
>> +static inline void folio_throttle_swaprate(struct folio *folio, gfp_t gfp_mask)
> 
> And it's not a gfp mask.  It's gfp_flags (we have this mistake all
> through the mm).  Or you can just call it 'gfp'.
> 
> 

Thanks for your kindly review and advise, will update.