linux-kernel - Re: [PATCH RESEND v2 5/5] sbitmap: correct wake_batch recalculation to avoid potential IO hung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16d02f7b-8e0e-097c-63bc-ef83eb9cb05b@huaweicloud.com>
Date:   Mon, 16 Jan 2023 10:15:08 +0800
From:   Kemeng Shi <shikemeng@...weicloud.com>
To:     Yu Kuai <yukuai1@...weicloud.com>, Jan Kara <jack@...e.cz>,
        Ming Lei <ming.lei@...hat.com>,
        "yukuai (C)" <yukuai3@...wei.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, kbusch@...nel.org,
        Laibin Qiu <qiulaibin@...wei.com>
Subject: Re: [PATCH RESEND v2 5/5] sbitmap: correct wake_batch recalculation
 to avoid potential IO hung



on 1/3/2023 10:12 AM, Kemeng Shi wrote:
> Friendly ping...
> 
> on 12/26/2022 4:57 PM, Yu Kuai wrote:
>> 在 2022/12/26 15:50, Yu Kuai 写道:
>>
>>>> why using
>>>> wake batch of 4 is safe for cards with say 32 tags in case active_users is
>>>> currently 32. Because I don't see why that is correct either.
>>>>
>>
>> I see, you guys are worried that during the period that some hctx
>> complete all it's not idle yet. It's right waiter might wait for
>> other hctx to become idle to be awaken in this case. However, I'm
>> not sure which way is better.
>>
>> Ming, do you have any idea?
>>
>> Thanks,
>> Kuai
>>
> 
Hi Jan. The magic batch 4 seems just for performance initially while
lacks of full consideration. And there is no better solution provided
in futher. Do you have any suggestion that I can do to make more
progress.

-- 
Best wishes
Kemeng Shi