linux-kernel - Re: [PATCH v3 0/19] irqdomain: fix mapping race and clean up locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8VXOQy09lJ+obLE@hovoldconsulting.com>
Date:   Mon, 16 Jan 2023 14:55:05 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Mark-PK Tsai <mark-pk.tsai@...iatek.com>
Cc:     johan+linaro@...nel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
        maz@...nel.org, platform-driver-x86@...r.kernel.org,
        tglx@...utronix.de, x86@...nel.org, yj.chiang@...iatek.com,
        phil.chang@...iatek.com
Subject: Re: [PATCH v3 0/19] irqdomain: fix mapping race and clean up locking

On Tue, Dec 20, 2022 at 11:30:42AM +0800, Mark-PK Tsai wrote:
> > Parallel probing (e.g. due to asynchronous probing) of devices that
> > share interrupts can currently result in two mappings for the same
> > hardware interrupt to be created.
> > 
> > This series fixes this mapping race and clean up the irqdomain locking
> > so that in the end the global irq_domain_mutex is only used for managing
> > the likewise global irq_domain_list, while domain operations (e.g.
> > IRQ allocations) use per-domain (hierarchy) locking.

> Tested-by: Mark-PK Tsai <mark-pk.tsai@...iatek.com>
> 
> We have the same issue and this patch series fix that.
> Thanks!
> 
> Link: https://lore.kernel.org/lkml/20221219130620.21092-1-mark-pk.tsai@mediatek.com/

Thanks for confirming. I just sent a v4 with a couple of clarifying
comments added to the final patch.

Johan