linux-kernel - Re: [PATCH AUTOSEL 5.10 11/17] spi: spidev: fix a race condition when accessing spidev->spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8VhxYxMjwtu12k2@sirena.org.uk>
Date:   Mon, 16 Jan 2023 14:40:05 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        linux-spi@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.10 11/17] spi: spidev: fix a race condition
 when accessing spidev->spi

On Mon, Jan 16, 2023 at 09:04:42AM -0500, Sasha Levin wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> [ Upstream commit a720416d94634068951773cb9e9d6f1b73769e5b ]
> 
> There's a spinlock in place that is taken in file_operations callbacks
> whenever we check if spidev->spi is still alive (not null). It's also
> taken when spidev->spi is set to NULL in remove().

There are ongoing discussions of race conditions with this commit.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)