linux-kernel - Re: [PATCH] Input: ipaq-micro-ts - fix DEFINE_SIMPLE_DEV_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230117171417.00002890@Huawei.com>
Date:   Tue, 17 Jan 2023 17:14:17 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Arnd Bergmann <arnd@...nel.org>
CC:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, <linux-input@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: ipaq-micro-ts - fix DEFINE_SIMPLE_DEV_PM_OPS
 typo

On Tue, 17 Jan 2023 17:45:33 +0100
Arnd Bergmann <arnd@...nel.org> wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> The previous change was not properly build tested and needs
> a trivial spelling change:
> 
> ipaq-micro-ts.c:146:8: error: type defaults to 'int' in declaration of 'DEFINE_SIMPLE_DEV_PM' [-Werror=implicit-int]
> 
> Fixes: 144ff5e03d74 ("Input: ipaq-micro-ts - use DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Hi Arnd,

I clearly messed up my build tests - will look into how that went wrong.
>From an initial look, this looks like a driver that could benefit from
a || COMPILE_TEST addition to the Kconfig depenencies. Nothing looks to be
build time dependent on the related MFD.

Thanks for fixing it up.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>


> ---
>  drivers/input/touchscreen/ipaq-micro-ts.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/ipaq-micro-ts.c b/drivers/input/touchscreen/ipaq-micro-ts.c
> index d8e25b502968..94720c41c9be 100644
> --- a/drivers/input/touchscreen/ipaq-micro-ts.c
> +++ b/drivers/input/touchscreen/ipaq-micro-ts.c
> @@ -143,8 +143,8 @@ static int micro_ts_resume(struct device *dev)
>  	return 0;
>  }
>  
> -static DEFINE_SIMPLE_DEV_PM(micro_ts_dev_pm_ops,
> -			    micro_ts_suspend, micro_ts_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(micro_ts_dev_pm_ops,
> +				micro_ts_suspend, micro_ts_resume);
>  
>  static struct platform_driver micro_ts_device_driver = {
>  	.driver	= {