linux-kernel - Re: [PATCH] qla2xxx: fix printk format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc47c99a-8315-ab73-8ab2-a26674cadf95@acm.org>
Date:   Tue, 17 Jan 2023 09:39:38 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Himanshu Madhani <himanshu.madhani@...cle.com>,
        Quinn Tran <qutran@...vell.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Saurav Kashyap <skashyap@...vell.com>,
        Tom Rix <trix@...hat.com>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qla2xxx: fix printk format string

On 1/17/23 09:00, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Printing a size_t value that is the result of the sizeof() operator requires
> using the %z format string modifier to avoid a warning on 32-bit architectures:
> 
> drivers/scsi/qla2xxx/qla_mid.c: In function 'qla_create_buf_pool':
> drivers/scsi/qla2xxx/qla_mid.c:1094:51: error: format '%ld' expects argument of type 'long int', but argument 5 has type 'unsigned int' [-Werror=format=]
>   1094 |                     "Failed to allocate buf_map(%ld).\n", sz * sizeof(unsigned long));
>        |                                                 ~~^       ~~~~~~~~~~~~~~~~~~~~~~~~~~
>        |                                                   |          |
>        |                                                   long int   unsigned int
>        |                                                 %d
> 
> Fixes: 82d8dfd2a238 ("scsi: qla2xxx: edif: Fix performance dip due to lock contention")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/scsi/qla2xxx/qla_mid.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_mid.c b/drivers/scsi/qla2xxx/qla_mid.c
> index c6ca39b8e23d..1483f6258f92 100644
> --- a/drivers/scsi/qla2xxx/qla_mid.c
> +++ b/drivers/scsi/qla2xxx/qla_mid.c
> @@ -1091,7 +1091,7 @@ int qla_create_buf_pool(struct scsi_qla_host *vha, struct qla_qpair *qp)
>   	qp->buf_pool.buf_map   = kcalloc(sz, sizeof(long), GFP_KERNEL);
>   	if (!qp->buf_pool.buf_map) {
>   		ql_log(ql_log_warn, vha, 0x0186,
> -		    "Failed to allocate buf_map(%ld).\n", sz * sizeof(unsigned long));
> +		    "Failed to allocate buf_map(%zd).\n", sz * sizeof(unsigned long));
>   		return -ENOMEM;
>   	}
>   	sz = qp->req->length * sizeof(void *);

Reviewed-by: Bart Van Assche <bvanassche@....org>