linux-kernel - Re: [PATCH] scsi: stex: fix MU_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <15f1424c-d979-6330-843c-d5ea84a8bfac@acm.org>
Date:   Tue, 17 Jan 2023 09:43:03 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Arnd Bergmann <arnd@...nel.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: stex: fix MU_MAX_DELAY typecheck

On 1/17/23 08:38, Arnd Bergmann wrote:
> @@ -173,7 +173,7 @@ enum {
>   	ST_ADDITIONAL_MEM_MIN			= 0x80000,
>   	PMIC_SHUTDOWN				= 0x0D,
>   	PMIC_REUMSE					= 0x10,
> -	ST_IGNORED					= -1,
> +	ST_IGNORED					= -1u,
>   	ST_NOTHANDLED				= 7,
>   	ST_S3						= 3,
>   	ST_S4						= 4,

 From drivers/scsi/stex.c:

int st_sleep_mic;

... st_sleep_mic == ST_IGNORED ...

Can changing ST_IGNORED from signed to unsigned break the stex driver?

Thanks,

Bart.