linux-kernel - Re: [PATCH] ARM: dts: omap: gta04: add BNO055 IMU chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230117203624.232be41c@aktux>
Date:   Tue, 17 Jan 2023 20:36:24 +0100
From:   Andreas Kemnade <andreas@...nade.info>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     bcousson@...libre.com, tony@...mide.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-omap@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: omap: gta04: add BNO055 IMU chip

On Sun, 15 Jan 2023 15:58:05 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> On 13/01/2023 23:10, Andreas Kemnade wrote:
> > There is finally a driver upstreamed, so add the
> > device.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> > ---
> >  arch/arm/boot/dts/omap3-gta04a5.dts | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts b/arch/arm/boot/dts/omap3-gta04a5.dts
> > index 0b5bd7388877..4f56f7fc0d1b 100644
> > --- a/arch/arm/boot/dts/omap3-gta04a5.dts
> > +++ b/arch/arm/boot/dts/omap3-gta04a5.dts
> > @@ -75,6 +75,11 @@ OMAP3_CORE1_IOPAD(0x2138, PIN_INPUT | MUX_MODE4) /* gpin114 */  
> >  		>;  
> >  	};
> >  
> > +	bno050_pins: pinmux-bno050-pins {
> > +		pinctrl-single,pins = <
> > +			OMAP3_CORE1_IOPAD(0x2136, PIN_INPUT | MUX_MODE4) /* gpin113 */
> > +		>;
> > +	};
> >  };
> >  
> >  /*
> > @@ -136,4 +141,13 @@ bme280@76 {
> >  		vdda-supply = <&vio>;
> >  		vddd-supply = <&vio>;
> >  	};
> > +
> > +	bno055@29 {  
> 
> Node names should be generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
the usual pitfall, just looking at the style around... Especially if it an
old patch, not needing too much attention, just removing some now undefined
properties. The file deserves some cleanup, since generic node names were
not invented there yet.

Regards,
Andreas