linux-kernel - Re: [PATCH v3] arm64: dts: qcom: sc7280: add display port audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Jan 2023 12:50:40 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Judy Hsiao <judyhsiao@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH v3] arm64: dts: qcom: sc7280: add display port audio

Hi,

On Mon, Jan 16, 2023 at 6:42 PM Judy Hsiao <judyhsiao@...omium.org> wrote:
>
> 1. Add DisplayPort sound node and lpass_cpu node.
>
> 2. Adjust the dai-link order to make the order to
>    be consistent with sc7280-herobrine-audio-rt5682-3mic.dtsi.
>
> Signed-off-by: Judy Hsiao <judyhsiao@...omium.org>
>
> ---
>
> Changes in v3:
> - Add more detail in the commit message.
>
> Changes in v2:
> - Fix the commit message format.
>
>  .../qcom/sc7280-herobrine-audio-rt5682.dtsi   | 19 ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)

nit: Your ${SUBJECT} needs to make it obvious what this is changing. Like maybe:

arm64: dts: qcom: sc7280: add DP audio to herobrine rt5682 1-mic dtsi

Other than that this looks good to me:

Reviewed-by: Douglas Anderson <dianders@...omium.org>