[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <874jsoluxd.ffs@tglx>
Date: Tue, 17 Jan 2023 22:20:46 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Johan Hovold <johan+linaro@...nel.org>,
Marc Zyngier <maz@...nel.org>
Cc: x86@...nel.org, platform-driver-x86@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
linux-kernel@...r.kernel.org,
Johan Hovold <johan+linaro@...nel.org>,
Hsin-Yi Wang <hsinyi@...omium.org>,
Mark-PK Tsai <mark-pk.tsai@...iatek.com>
Subject: Re: [PATCH v4 04/19] irqdomain: Fix association race
On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote:
> The sanity check for an already mapped virq was done outside of the
s/was/is/
> irq_domain_mutex-protected section which meant that an (unlikely) racing
s/meant/means/
> association may not be detected.
You describe the status quo and then correctly what the fix is:
> Fix this by factoring out the association implementation, which will
> also be used in follow-on changes to rework the locking.
Otherwise your fix fixes something which existed in the past, no?
Thanks,
tglx
Powered by blists - more mailing lists