linux-kernel - Re: [PATCH] firmware: imx-dsp: Fix an error handling path in imx_dsp_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZC=JNGixTRVDnEK0p5rZWuQbOmQvApTUM5=0iJN9pzVRw@mail.gmail.com>
Date:   Tue, 17 Jan 2023 09:55:04 +0200
From:   Daniel Baluta <daniel.baluta@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Daniel Baluta <daniel.baluta@....com>,
        Paul Olaru <paul.olaru@....com>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] firmware: imx-dsp: Fix an error handling path in imx_dsp_setup_channels()

On Sun, Jan 15, 2023 at 8:35 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> If mbox_request_channel_byname() fails, the memory allocated a few lines
> above still need to be freed before going to the error handling path.
>
> Fixes: 046326989a18 ("firmware: imx: Save channel name for further use")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Good catch.

Reviewed-by: Daniel Baluta <daniel.baluta@....com>