linux-kernel - Re: [PATCH v2 3/4] soc: qcom: pmic_glink: Introduce altmode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230117020848.7i4znoynf6q5vtom@builder.lan>
Date:   Mon, 16 Jan 2023 20:08:48 -0600
From:   Bjorn Andersson <andersson@...nel.org>
To:     Steev Klimaszewski <steev@...i.org>
Cc:     Bjorn Andersson <quic_bjorande@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Subbaraman Narayanamurthy <quic_subbaram@...cinc.com>,
        Johan Hovold <johan@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v2 3/4] soc: qcom: pmic_glink: Introduce altmode support

On Sun, Jan 15, 2023 at 01:10:14PM -0600, Steev Klimaszewski wrote:
> > diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c
[..]
> > +       msg = data;
> > +       notification = le32_to_cpu(msg->notification);
> > +       port = FIELD_GET(SC8180X_PORT_MASK, notification);
> > +       orientation = FIELD_GET(SC8180X_ORIENTATION_MASK, notification);
> > +       mux = FIELD_GET(SC8180X_MUX_MASK, notification);
> > +       mode = FIELD_GET(SC8180X_MODE_MASK, notification);
> > +       hpd_state = FIELD_GET(SC8180X_HPD_STATE_MASK, notification);
> > +       hpd_irq = FIELD_GET(SC8180X_HPD_IRQ_MASK, notification);
> > +
> The kernel test robot keeps complaining about these FIELD_GET because
> there is no #include <linux/bitfield.h>
> 

I must have missed those complains before, thanks for pointing it out!

Regards,
Bjorn