linux-kernel - Re: [PATCH] irqchip/imx: Do not unconditionally enable GENERIC_MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wn5lldh7.ffs@tglx>
Date:   Tue, 17 Jan 2023 10:25:24 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Cc:     linux-tip-commits@...r.kernel.org,
        Jason Gunthorpe <jgg@...dia.com>, x86@...nel.org,
        maz@...nel.org
Subject: Re: [PATCH] irqchip/imx: Do not unconditionally enable GENERIC_MSI_IRQ

On Fri, Jan 13 2023 at 13:17, Ingo Molnar wrote:
>   config IMX_MU_MSI
>         tristate "i.MX MU used as MSI controller"
>         depends on OF && HAS_IOMEM
>         depends on ARCH_MXC || COMPILE_TEST
>         default m if ARCH_MXC
>         select IRQ_DOMAIN
>         select IRQ_DOMAIN_HIERARCHY
>         select GENERIC_MSI_IRQ
>         help
>
> But that's not unconditionally valid - for example on x86 UP kernel builds
> that have the local APIC disabled there's no MSI functionality - resulting
> in build failures like:
>
>   ./include/linux/gpio/driver.h:32:33: error: field ‘msiinfo’ has incomplete type
>   kernel/irq/msi.c:739:19: error: invalid use of incomplete typedef ‘msi_alloc_info_t’ {aka ‘struct irq_alloc_info’}

What prevents us from either

  - exposing msi_alloc_info_t unconditionally (it should not matter)

or

  - killing that 32bit UP && APIC=n combo (which removes quite some
    ifdef cruft)


Thanks,

        tglx