linux-kernel - Re: [RFC PATCH] irqchip/gic-v3: wait irq done to set affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tu0plcv2.ffs@tglx>
Date:   Tue, 17 Jan 2023 10:38:41 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Yipeng Zou <zouyipeng@...wei.com>, Marc Zyngier <maz@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        hewenliang4@...wei.com, chris.zjh@...wei.com, liaochang1@...wei.com
Subject: Re: [RFC PATCH] irqchip/gic-v3: wait irq done to set affinity

On Mon, Jan 09 2023 at 20:26, Yipeng Zou wrote:
> 在 2023/1/6 19:55, Marc Zyngier 写道:
> index 973ede0197e3..fad08ccb7fd9 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -1667,6 +1667,9 @@ static int its_set_affinity(struct irq_data *d, 
> const struct cpumask *mask_val,
>
>          /* don't set the affinity when the target cpu is same as 
> current one */
>          if (cpu != prev_cpu) {
> +
> +               // wait irq done on all cpus
> +

There is no way to wait here. The caller holds the interrupt descriptor
lock.

If this is really an issue for LPI, then the only way to deal with that
is CONFIG_GENERIC_PENDING_IRQ, which delays the affinity change to
interrupt context

Why on earth must all the known hardware mistakes be repeated over and
over?

Thanks,

        tglx