[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <a699e52a-db19-4374-a4bc-a3948ecc43ef@app.fastmail.com>
Date: Tue, 17 Jan 2023 11:15:20 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Nikita Shubin" <nikita.shubin@...uefel.me>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Cc: "Linus Walleij" <linus.walleij@...aro.org>,
"Hartley Sweeten" <hsweeten@...ionengravers.com>,
"Alexander Sverdlin" <alexander.sverdlin@...il.com>,
"Russell King" <linux@...linux.org.uk>,
"Lukasz Majewski" <lukma@...x.de>,
"Bartosz Golaszewski" <brgl@...ev.pl>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] gpio: ep93xx: convert driver to DT
On Tue, Jan 17, 2023, at 11:08, Nikita Shubin wrote:
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id ep93xx_gpio_match[] = {
> + { .compatible = "cirrus,ep93xx-gpio" },
> + { /* end of table */ },
> +};
> +MODULE_DEVICE_TABLE(of, ep93xx_gpio_match);
> +#endif
> +
> static struct platform_driver ep93xx_gpio_driver = {
> .driver = {
> .name = "gpio-ep93xx",
> + .of_match_table = ep93xx_gpio_match,
> },
> .probe = ep93xx_gpio_probe,
The #ifdef here is wrong and will cause a build failure because
of the unconditional reference to the variable.
Just remove the #ifdef/#endif.
Arnd
Powered by blists - more mailing lists