[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230117112959.omsjmx4gmhnoaxj3@pengutronix.de>
Date: Tue, 17 Jan 2023 12:29:59 +0100
From: Marco Felsch <m.felsch@...gutronix.de>
To: Sakari Ailus <sakari.ailus@....fi>
Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>, mchehab@...nel.org,
laurent.pinchart+renesas@...asonboard.com,
jacopo+renesas@...ndi.org, akinobu.mita@...il.com,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel@...gutronix.de
Subject: Re: [PATCH 3/4] media: mt9m111: fix device power usage
Hi Sakari,
On 23-01-17, Sakari Ailus wrote:
> Hi Marco,
>
> On Tue, Aug 23, 2022 at 04:44:50PM +0200, Marco Felsch wrote:
> > Hi Sakari,
> >
> > On 22-08-22, Sakari Ailus wrote:
> > > On Mon, Aug 22, 2022 at 09:54:26AM +0200, Marco Felsch wrote:
> > > > Hi Sakari,
> > > >
> > > > On 22-08-22, Sakari Ailus wrote:
> > > > > Hi Marco,
> > > > >
> > > > > On Thu, Aug 18, 2022 at 04:47:11PM +0200, Marco Felsch wrote:
> > > > > > Currently the driver turn off the power after probe and toggle it during
> > > > > > .stream by using the .s_power callback. This is problematic since other
> > > > > > callbacks like .set_fmt accessing the hardware as well which will fail.
> > > > > > So in the end the default format is the only supported format.
> > > > >
> > > > > It'd be much better to add runtime PM support to the driver instead.
> > > >
> > > > I got your point, but didn't have the time for it right now, I will drop
> > > > the patch from my v2.
> > >
> > > The API is different but generally involves doing more or less the same
> > > what this and the 4th patch do together.
> >
> > I know :) as soon as I got feedback on my TC35 series [1] I give it a
> > try and change it to dev-pm.
>
> What's the status of this set?
>
> These are nice improvements but I was expecting v2.
Unfortunately this was just a testing vehicle I had for the TC35 bridge
chip. As soon as I have access to it again I will send a new version.
Regards,
Marco
Powered by blists - more mailing lists