linux-kernel - Re: [PATCH 0/2] Cover Letter: HID: drop assumptions on non-empty report lists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2301171310140.1734@cbobk.fhfr.pm>
Date:   Tue, 17 Jan 2023 13:10:40 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Pietro Borrello <borrello@...g.uniroma1.it>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Kees Cook <keescook@...omium.org>, Hanno Zulla <abos@...no.de>,
        Cristiano Giuffrida <c.giuffrida@...nl>,
        "Bos, H.J." <h.j.bos@...nl>, Jakob Koschel <jkl820.git@...il.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] Cover Letter: HID: drop assumptions on non-empty
 report lists

On Mon, 16 Jan 2023, Pietro Borrello wrote:

> We found potential misuses of list_entry() on lists in hid driver
> code that are not checked.
> Issuing a list_entry() on an empty list causes a type confusion making
> the list_entry point to the list_head itself.
> The most impactful seems the missing check for an empty list in
> hid_validate_values() which is supposed to check the validity of the
> reports themselves, potentially affecting all the drivers that rely on it.

Both applied to hid.git#for-6.2/upstream-fixes. Thanks Pietro,

-- 
Jiri Kosina
SUSE Labs