linux-kernel - RE: [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYAPR01MB62012C375164A60ED102929592C69@TYAPR01MB6201.jpnprd01.prod.outlook.com>
Date:   Tue, 17 Jan 2023 12:29:39 +0000
From:   <yuji2.ishikawa@...hiba.co.jp>
To:     <krzk@...nel.org>, <hverkuil@...all.nl>,
        <laurent.pinchart@...asonboard.com>, <mchehab@...nel.org>,
        <nobuhiro1.iwamatsu@...hiba.co.jp>
CC:     <linux-media@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: RE: [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add
 Toshiba Visconti Video Input Interface bindings

Hello Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Thursday, January 12, 2023 5:11 PM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@...hiba.co.jp>; hverkuil@...all.nl;
> laurent.pinchart@...asonboard.com; mchehab@...nel.org; iwamatsu
> nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) <nobuhiro1.iwamatsu@...hiba.co.jp>
> Cc: linux-media@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; devicetree@...r.kernel.org
> Subject: Re: [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add Toshiba
> Visconti Video Input Interface bindings
> 
> On 12/01/2023 03:05, yuji2.ishikawa@...hiba.co.jp wrote:
> >>>> Compatible must be specific. You called your SoC visconti5, didn't you?
> >>>>
> >>>
> >>> The Video Input Interface hardware is likely to be used at future
> >>> SoCs of Visconti Architecture.
> >>> Does compatible have to be specific to SoC's model name rather than
> >>> architecture name?
> >>
> >> Compatibles should always be specific to SoC model name. Adding more
> >> generic family fallback is also good idea when it is applicable.
> >>
> >
> > I'll update the compatible to "toshiba,visconti5-viif".
> > I'll consider adding generic version "toshiba,visconti-viif" when a successor
> SoC gets available.
> 
> Are you sure? You will have to wait at least one cycle between DTS and driver
> change, due to ABI break of DTB users.

Thank you for the advice. I've come to understand the risk.
I would still use only "toshiba,visconti5-viif",
because there's enough time for internal evaluation before product release.
I can work on DTS and driver change with that time.

> 
> Best regards,
> Krzysztof

Regards,
Yuji