linux-kernel - Re: [PATCH v1 2/3] gpio: pcf857x: Make use of device properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaAicyx0Pzwc7oP+x=kM7DCKi2YJ_rqPnt2_9jKCfCwvQ@mail.gmail.com>
Date:   Tue, 17 Jan 2023 13:41:14 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 2/3] gpio: pcf857x: Make use of device properties

On Mon, Jan 16, 2023 at 1:46 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:

> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
>
> Add mod_devicetable.h include.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

LGTM:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

> -       of_property_read_u32(np, "lines-initial-states", &n_latch);
> +       device_property_read_u32(&client->dev, "lines-initial-states", &n_latch);

Haha we even managed to sneak in an official property for this,
I don't know when that happened but very good to have, this
is the first time I see it used actually.

Now I will recommend everyone with this problem to just
follow the PCF857x example.

Yours,
Linus Walleij