[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ddb81fcb-b353-ce7f-8b12-9cdcbfcacb8e@collabora.com>
Date: Tue, 17 Jan 2023 13:52:19 +0100
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Alexandre Mergnat <amergnat@...libre.com>,
Rob Herring <robh+dt@...nel.org>,
Qii Wang <qii.wang@...iatek.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Matthias Brugger <matthias.bgg@...il.com>
Cc: linux-i2c@...r.kernel.org, Rob Herring <robh@...nel.org>,
Fabien Parent <fparent@...libre.com>,
linux-arm-kernel@...ts.infradead.org,
Kevin Hilman <khilman@...libre.com>,
linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: mediatek: add i2c support for mt8365 SoC
Il 17/01/23 09:49, Alexandre Mergnat ha scritto:
> There are four I2C master channels in MT8365 with a same HW architecture.
>
> Signed-off-by: Alexandre Mergnat <amergnat@...libre.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8365.dtsi | 60 ++++++++++++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> index a32f2b7507be..3c2819bd32af 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> @@ -282,6 +282,66 @@ pwm: pwm@...06000 {
> clock-names = "top", "main", "pwm1", "pwm2", "pwm3";
> };
>
> + i2c0: i2c@...07000 {
> + compatible = "mediatek,mt8365-i2c",
> + "mediatek,mt8168-i2c";
> + reg = <0 0x11007000 0 0xa0>,
> + <0 0x11000080 0 0x80>;
Compatibles fit in one line (83 columns is fine);
regs fit in one line, reaching 76 columns.
Same comments for the other nodes that you're adding.
Regards,
Angelo
Powered by blists - more mailing lists