[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y8aesLLS3sBPwLQY@liuwe-devbox-debian-v2>
Date: Tue, 17 Jan 2023 13:12:16 +0000
From: Wei Liu <wei.liu@...nel.org>
To: Jinank Jain <jinankjain@...ux.microsoft.com>
Cc: Tom Rix <trix@...hat.com>, kys@...rosoft.com,
haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
dave.hansen@...ux.intel.com, hpa@...or.com, mikelley@...rosoft.com,
nunodasneves@...ux.microsoft.com, x86@...nel.org,
linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/hyperv: conditionally build hv_get_nested_reg()
On Tue, Jan 17, 2023 at 03:41:18PM +0530, Jinank Jain wrote:
> Reviewed-by: Jinank Jain <jinankjain@...ux.microsoft.com>
>
I will just fold this into the buggy patch since that has not been sent
to Linus.
Thanks Tom and Jinank.
> On 1/14/2023 7:26 AM, Tom Rix wrote:
> > cppcheck reports
> > [arch/x86/kernel/cpu/mshyperv.c:44]: (style) The function 'hv_get_nested_reg' is never used.
> >
> > hv_get_nested_reg() is built unconditially but is only used conditionally in
> > hv_get_register() and hv_set_register() by CONFIG_HYPERV.
> >
> > Move the conditional #if to also include hv_get_nested_reg()
> >
> > Fixes: 89acd9b2ff8e ("Drivers: hv: Setup synic registers in case of nested root partition")
> > Signed-off-by: Tom Rix <trix@...hat.com>
> > ---
> > arch/x86/kernel/cpu/mshyperv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> > index b8bb13daacf7..9ca202970569 100644
> > --- a/arch/x86/kernel/cpu/mshyperv.c
> > +++ b/arch/x86/kernel/cpu/mshyperv.c
> > @@ -41,6 +41,7 @@ bool hv_root_partition;
> > bool hv_nested;
> > struct ms_hyperv_info ms_hyperv;
> > +#if IS_ENABLED(CONFIG_HYPERV)
> > static inline unsigned int hv_get_nested_reg(unsigned int reg)
> > {
> > switch (reg) {
> > @@ -61,7 +62,6 @@ static inline unsigned int hv_get_nested_reg(unsigned int reg)
> > }
> > }
> > -#if IS_ENABLED(CONFIG_HYPERV)
> > u64 hv_get_non_nested_register(unsigned int reg)
> > {
> > u64 value;
Powered by blists - more mailing lists