linux-kernel - Re: [PATCH v3 8/9] interconnect: qcom: rpm: Add a way to always set QoS registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e35de82-e539-35c1-fcb1-10c02af9bb8c@linaro.org>
Date:   Tue, 17 Jan 2023 13:27:40 +0000
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        linux-arm-msm@...r.kernel.org, andersson@...nel.org,
        agross@...nel.org, krzysztof.kozlowski@...aro.org
Cc:     marijn.suijten@...ainline.org, Georgi Djakov <djakov@...nel.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 8/9] interconnect: qcom: rpm: Add a way to always set
 QoS registers

On 16/01/2023 13:21, Konrad Dybcio wrote:
> On newer SoCs (there's no clear boundary, but probably "new enough"
> means every interconnect provider is either BIMC or QNoC and there
> are no old-style NoC hosts) we're expected to set QoS registers
> regardless of the ap_owned param. Add a bool in the qcom_icc_provider
> and make the logic assume it's okay to set the registers when it's
> set.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
>   drivers/interconnect/qcom/icc-rpm.c | 2 +-
>   drivers/interconnect/qcom/icc-rpm.h | 2 ++
>   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
> index 509cadf398e9..343e6021a93a 100644

On next-20230116,

git am < 
~/Downloads/v3-1-9-interconnect-qcom-rpm-make-QoS-INVALID-default-separate-out-driver-data.patch
Applying: interconnect: qcom: rpm: make QoS INVALID default, separate 
out driver data
Applying: interconnect: qcom: rpm: Add support for specifying channel num
Applying: interconnect: qcom: rpm: Rename icc desc clocks to bus_blocks
Applying: interconnect: qcom: rpm: Add a way to always set QoS registers

error: patch failed: drivers/interconnect/qcom/icc-rpm.c:243
error: drivers/interconnect/qcom/icc-rpm.c: patch does not apply
error: patch failed: drivers/interconnect/qcom/icc-rpm.h:28
error: drivers/interconnect/qcom/icc-rpm.h: patch does not apply
Patch failed at 0004 interconnect: qcom: rpm: Add a way to always set 
QoS registers
hint: Use 'git am --show-current-patch=diff' to see the failed patch

Should I pick up another series from elsewhere to apply this ?

---
bod