linux-kernel - Re: [PATCH 6.1] netfilter: Null pointer dereference in nf_tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8a+RddrpMz7cUdC@salvia>
Date:   Tue, 17 Jan 2023 16:27:01 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Alok Tiwari <alok.a.tiwari@...cle.com>
Cc:     linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org
Subject: Re: [PATCH 6.1] netfilter: Null pointer dereference in
 nf_tables_updobj

On Tue, Jan 17, 2023 at 03:17:11PM +0100, Pablo Neira Ayuso wrote:
> On Tue, Jan 17, 2023 at 05:45:38AM -0800, Alok Tiwari wrote:
> > static analyzer detect null pointer dereference case for 'type'
> > function __nft_obj_type_get() can return NULL value which require to handle
> > if type is NULL pointer return -ENOENT
> 
> This should not ever happen, but it is good to have a failsafe in this
> path.
> 
> I'll take this into nf.git, thanks.

BTW, easier to read:

        if (WARN_ON_ONCE(!type))

instead of:

        if (!WARN_ON_ONCE(type))

I'll mangle the patch here before applying, unless you prefer to send a v2.