linux-kernel - Re: [PATCH v2 6.1] netfilter: Null pointer dereference in nf_tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y8bEKooxegoRSbkO@salvia>
Date:   Tue, 17 Jan 2023 16:52:10 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Alok Tiwari <alok.a.tiwari@...cle.com>
Cc:     linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
        darren.kenny@...cle.com
Subject: Re: [PATCH v2 6.1] netfilter: Null pointer dereference in
 nf_tables_updobj

On Tue, Jan 17, 2023 at 07:45:49AM -0800, Alok Tiwari wrote:
> static analyzer detect null pointer dereference case for 'type'
> function __nft_obj_type_get() can return NULL value which require to handle
> if type is NULL pointer return -ENOENT

Applied, thanks.

I have appended:

This should not ever happen, because if an object is found, then that
implies there is an object type, but let's add this as a failsafe check.