linux-kernel - Re: [RFC] USB: core: Add wireless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8bJbM0+XcT6MRq9@kroah.com>
Date:   Tue, 17 Jan 2023 17:14:36 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bastien Nocera <hadess@...ess.net>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [RFC] USB: core: Add wireless_status sysfs attribute

On Tue, Jan 17, 2023 at 04:17:23PM +0100, Bastien Nocera wrote:
> Hey,
> 
> TLDR: new sysfs attribute that makes it possible to leave receivers for
> wireless headsets plugged in. At the USB level, or at the base driver
> level?
> 
> Longer version:
> I started working on implementing support for some wireless headsets
> that use USB receivers to communicate to the headset itself.

Would this also include wireless keyboard/mice recievers?

Why is "wireless" somehow a special attribute that userspace needs to
know about?

> The USB receivers have multiple interfaces, and independent drivers for
> each, as is wont to do for USB devices. There's usually a HID interface
> to do the custom stuff (LEDs, battery status, connection status, etc.)
> and a standard audio class interface.

This probably should be an interface attribute (as Alan points out), as
it's not a device attribute (think about updating the firmware for one
of these, that's on an interface for the reciever you plugged in, not on
the other end of the wireless connection...)

> Those drivers don't know anything about each other, and getting them to
> talk to each other would be rather complicated. Additionally the audio
> interface is still somewhat functional when the headset is
> disconnected.

Those drivers shouldn't know about each other, that's up to userspace to
group and control if needed.  No kernel interactions should be needed.

> In the end, I came up with this new sysfs attribute that would make it
> possible for user-space (PulseAudio or Pipewire) to know whether the
> receiver is plugged in or not.

Again, should be an interface attribute, if at all.

> That allows user-space to not show the battery information for the
> device (rather than 0 percent), not offer the headset as an output, and
> potentially automatically switch to it when the headset is powered on.

Same for a keyboard/mouse, right?

thanks,

greg k-h