[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1afecb9c-b17c-d2a5-d887-b7dced939586@intel.com>
Date: Tue, 17 Jan 2023 08:43:03 -0800
From: Russ Weight <russell.h.weight@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
<linux-fpga@...r.kernel.org>, Xu Yilun <yilun.xu@...el.com>,
Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
Moritz Fischer <mdf@...nel.org>, Lee Jones <lee@...nel.org>,
Matthew Gerlach <matthew.gerlach@...ux.intel.com>,
Tianfei zhang <tianfei.zhang@...el.com>,
Mark Brown <broonie@...nel.org>,
Marco Pagani <marpagan@...hat.com>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 01/11] mfd: intel-m10-bmc: Add missing includes to
header
On 1/16/23 02:08, Ilpo Järvinen wrote:
> linux/mfd/intel-m10-bmc.h is using:
> - pr_err(), thus include also linux/dev_printk.h
> - FIELD_GET(), this include also linux/bitfield.h
> - GENMASK(), thus include also linux/bits.h
Reviewed-by: Russ Weight <russell.h.weight@...el.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
> include/linux/mfd/intel-m10-bmc.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/mfd/intel-m10-bmc.h b/include/linux/mfd/intel-m10-bmc.h
> index f0044b14136e..0d4db5d9d5af 100644
> --- a/include/linux/mfd/intel-m10-bmc.h
> +++ b/include/linux/mfd/intel-m10-bmc.h
> @@ -7,6 +7,9 @@
> #ifndef __MFD_INTEL_M10_BMC_H
> #define __MFD_INTEL_M10_BMC_H
>
> +#include <linux/bitfield.h>
> +#include <linux/bits.h>
> +#include <linux/dev_printk.h>
> #include <linux/regmap.h>
>
> #define M10BMC_LEGACY_BUILD_VER 0x300468
Powered by blists - more mailing lists