linux-kernel - Re: [PATCH] xen: Allow platform PCI interrupt to be shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0b75988-bee6-e0c7-0dda-86e1e973ba74@citrix.com>
Date:   Wed, 18 Jan 2023 13:53:28 +0000
From:   Andrew Cooper <Andrew.Cooper3@...rix.com>
To:     David Woodhouse <dwmw2@...radead.org>,
        Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        xen-devel <xen-devel@...ts.xenproject.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Paul Durrant <paul@....org>
Subject: Re: [PATCH] xen: Allow platform PCI interrupt to be shared

On 18/01/2023 12:22 pm, David Woodhouse wrote:
> Signed-off-by: David Woodhouse <dwmw@...zon.co.uk>
> ---
> What does xen_evtchn_do_upcall() exist for? Can we delete it? I don't
> see it being called anywhere.

Seems the caller was dropped by
cb09ea2924cbf1a42da59bd30a59cc1836240bcb, but the CONFIG_PVHVM looks
bogus because the precondition to setting it up was being in a Xen HVM
guest, and the guest is taking evtchns by vector either way.

PV guests use the entrypoint called exc_xen_hypervisor_callback which
really ought to gain a PV in its name somewhere.  Also the comments look
distinctly suspect.

Some tidying in this area would be valuable.

~Andrew