[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b9fa44e8-3387-df90-7997-cac74312cb3b@linaro.org>
Date: Wed, 18 Jan 2023 03:24:34 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Jiasheng Jiang <jiasheng@...as.ac.cn>, robdclark@...il.com,
quic_abhinavk@...cinc.com, sean@...rly.run, airlied@...il.com,
sumit.semwal@...aro.org, christian.koenig@....com
Cc: linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
linaro-mm-sig@...ts.linaro.org, freedreno@...ts.freedesktop.org
Subject: Re: [PATCH v2] drm/msm: Add missing check and destroy for
alloc_ordered_workqueue
On 09/01/2023 04:20, Jiasheng Jiang wrote:
> Add check for the return value of alloc_ordered_workqueue as it may return
> NULL pointer.
> Moreover, use the destroy_workqueue in the later fails in order to avoid
> memory leak.
>
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Convert "goto err_destroy_workqueue" into "goto err_msm_unit" and
> remove "err_destroy_workqueue" label.
> ---
> drivers/gpu/drm/msm/msm_drv.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
--
With best wishes
Dmitry
Powered by blists - more mailing lists