linux-kernel - Re: [PATCH] arm64: dts: renesas: r9a09g011: Reword ethernet status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y8gLTxuedrE2TUfq@pendragon.ideasonboard.com>
Date:   Wed, 18 Jan 2023 17:07:59 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Fabrizio Castro <fabrizio.castro.jz@...esas.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        Biju Das <biju.das@...renesas.com>,
        Jacopo Mondi <jacopo@...ndi.org>
Subject: Re: [PATCH] arm64: dts: renesas: r9a09g011: Reword ethernet status

Hi Fabrizio,

Thank you for the patch.

On Wed, Jan 18, 2023 at 01:52:59PM +0000, Fabrizio Castro wrote:
> Although of_fdt_device_is_available returns true when the DT
> property "status" is assigned "ok" or "okay", and false for every
> other value, it's become common practice to assign "disabled"
> when we want of_fdt_device_is_available to return false.
> For some reason, the status property of the ethernet node was
> assigned "disable" when originally added to the kernel. Change
> it to "disabled" for consistency.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

> ---
>  arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
> index dd35a8ff72ee..b0c066c5e0ba 100644
> --- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
> @@ -165,7 +165,7 @@ avb: ethernet@...00000 {
>  			power-domains = <&cpg>;
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> -			status = "disable";
> +			status = "disabled";
>  		};
>  
>  		cpg: clock-controller@...00000 {

-- 
Regards,

Laurent Pinchart